Attention is currently required from: Namyoon Woo.
View Change
1 comment:
File dummyflasher.c:
Patch Set #2, Line 713: data->spi_write_256_chunksize = atoi(tmp);
For another patch: This can result in overflow because `spi_write_256_chunksize` is of an unsigned t […]
Indeed, Thanks as always Angel. I noticed one other atoi rot in serprog.c too.
https://review.coreboot.org/c/flashrom/+/54854
To view, visit change 54721. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I633f4df4bd47e661cd69801f21910b667899d505
Gerrit-Change-Number: 54721
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Namyoon Woo <namyoon@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Namyoon Woo <namyoon@google.com>
Gerrit-Comment-Date: Sun, 23 May 2021 12:25:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment