Attention is currently required from: Nico Huber.

View Change

1 comment:

• File ichspi.c:

  • Patch Set #7, Line 872: write_cmd = true;

    (Also not nice to change the style that the original author choose, IMO.)

    Why should the bool type be a problem for the author but not a change to the variable name? It might be not wanted by the author? Maybe the author doesn't like it?

    This is an open source project and not anyones personal project.

    
    > Changing the same lines over and over again also unnecessarily drains review resources.

    How much time did it take to write these two comments? I guess you wasted more of your time with writing these comments than with actually reviewing this patch.

    I think this discussion is pointless and I feel like you are creating arguments for no reason. I'm not going to dive into this discussion anymore as long as there are no real arguments against this patch, because this drains my resources unnecessarily.

To view, visit change 66892. To unsubscribe, or for help writing mail filters, visit settings.