Attention is currently required from: Felix Singer, Nico Huber, Subrata Banik.
View Change
2 comments:
Commit Message:
Patch Set #6, Line 7: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently
I rather would like to use the functions instead of the macros.
Same, but the point here is that future work is a lot easier with consistent code not half complete revisions of what is best.
Patch Set #6, Line 14: TEST=builds
As far as I can see, the binary shouldn't change. Please make sure this is the case.
Yes, everything ends up as the same.
To view, visit change 64968. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8c90ea1ff617a451a671827d7bc49679d349c79d
Gerrit-Change-Number: 64968
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 00:22:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Gerrit-MessageType: comment