Patch set 1:Code-Review -2
1 comment:
/* wpce775x.c */
int wpce775x_probe_spi_flash(const char *name);
needs guards. needs adding to the dispatch table in flashrom.c and also it should be added to meson as well as the Makefile. All the global state in wpce775x needs to go into a struct and put inside the spi master opaque void * data field. This all needs to be cleaned up in our tree before we wast upstreams limited resources and time. A couple of WIP patches is fine but not too many.
Honestly wpce775x needs plenty of clean ups in our tree before throwing our tech debt at upstream. This code is just too bad to send upstream in its current form.
Please continue to drive landing s25f work as it looks like it is almost there, perhaps some unit-tests would be great and seem very possible with s25f.
To view, visit change 47641. To unsubscribe, or for help writing mail filters, visit settings.