Many thanks for the review! :)

>> How about risking it on master and guarding on the 1.0.x
>> cherry-pick?

I'll do just that to be safe. Style doesn't matter on the branch.

I tried to find some source to support that recollection but I can't, so for what it's worth, feel free to do it.

At the point where these free()s happen (and a crash would occur), everything crucial has been done anyway.

That too.

Btw. do you know any easy way to test Solaris? some
live image that you could just boot in qemu, maybe?

View Change

To view, visit change 31068. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5fc35310f0b090f218cd1d660e27fb39dd05c3c5
Gerrit-Change-Number: 31068
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: Arthur Heymans <>
Gerrit-Reviewer: David Hendricks <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-Comment-Date: Mon, 04 Mar 2019 14:47:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment