Attention is currently required from: Felix Singer, Nico Huber.
View Change
1 comment:
File Makefile:
Patch Set #1, Line 795: ,$(DEPENDS_ON_SERIAL)),yes,no)
the `filter_deps` function can't handle spaces yet. All existing calls are like this.
Additionally the result of $(if ..., yes, no) need to get stripped. Otherwise the result is " yes" / " no" and not "yes" / "no". The best way would be another function. Something for later.
To view, visit change 62196. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66
Gerrit-Change-Number: 62196
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 13:27:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Gerrit-MessageType: comment