Attention is currently required from: Edward O'Callaghan, Daniel Campello, Peter Marheine.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    I think all you need to do is to take the first change in flashrom. […]

    But the reference patch already exists (CB:52362), why would I duplicate a chunk of it in another patch? My understanding of situation is that CB:52362 is not going anywhere because no one approves it. And I agree with Peter, it seems wrong to call read_flash_to_file without a filename.

    In any case, CB:52362 has a goal of "Make -r/-w/-v argument optional" which does not mention -x at all. I can see it fixes do_extract, but it is kind of a side-effect.

    As I said, I would really prefer to re-write do_extract to only do what it needs to do. If the only thing from read_flash_to_file which is useful is write_buf_to_include_args, then let's just call write_buf_to_include_args?

To view, visit change 59532. To unsubscribe, or for help writing mail filters, visit settings.