Attention is currently required from: Nico Huber, Sergii Dmytruk.

View Change

1 comment:

• File writeprotect.c:

  • Patch Set #1, Line 159: new

    I'm also not sure if test terminology is more appropriate here than old/new or current/new, but one […]

    The key point here is that it is consistent and in keeping with the rest of the file.

    In direct answer to the question - it is the 'expected bits the caller requested' and the 'actual bits observed' from the chip.

    As an aside without going off in the deep end here, "new/old" doesn't really make much sense either, 'new what'. Furthermore 'new' is typically a reserved word in most languages and tends to be best avoided as a identifier for a variable.

To view, visit change 66754. To unsubscribe, or for help writing mail filters, visit settings.