Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
3 comments:
Commit Message:
Yes you are right, I will do this. […]
Environment this applies to: __xstat64 wrap is needed to run unit tests with emerge under chromium chroot.
When I run same tests, in the same chromium tree, with meson, then stat64 is called.
There was, as I understand, some change in chromium chroot recently, which caused the switch from stat64 to __xstat64, however I couldn't find what exactly has changed.
Good news: "some flashrom developer" won't have a failing test locally, because this only affects people who are running tests with emerge under chromium chroot.
Bad news: this affects me :( Partially, because I can work on upstream tree as usual.
I will re-write commit message later today, I agree it is too vague.
Did I answer your question about environment? Let me know if not!
TEST=running tests on two different environments,
with 1) stat64 and 2) __xstat64 invoked
Yes sure, I will do this. Let's keep this comment unresolved.
I looked into all potentially relevant minijail policies, could not find any recent policy change that would look like it caused switching from stat64 to __xstat64. Maybe it's not minijail.
> before being sure we need this wrap
Currently, anyone who wants to run unit tests with emerge under chroot, needs this wrap. I think we need it...
Patchset:
Sorry for delay, I was gathering info. I am back.
To view, visit change 58103. To unsubscribe, or for help writing mail filters, visit settings.