Tried to find some documentation on the matter which raised more
questions. Code looks fine, so far.

Patch set 6:Code-Review +1

View Change

4 comments:

• File buspirate_spi.c:

  • Patch Set #4, Line 497: bp_commbuf[0] = 0x00;

    Good catch, I'll fix that. […]

    Yes, I meant msg_pinfo() but was in doubt anyway. msg_pdbg() is
    just fine.

• File buspirate_spi.c:

  • Patch Set #6, Line 443: 5.5

    Where is this written? This page talks about 5.2:

    http://dangerousprototypes.com/docs/Bus_Pirate_menu_options_guide#B_Set_PC_side_serial_port_speed

  • Patch Set #6, Line 451: " Continue at your own risk.\n");

    I did some research, v2 can work with the same firmware and uses the
    same microcontroller and USB converter as v3. So that should be fine.
    Maybe remove the warning for v2 but keep it at default 115200 because
    we can't test it?

  • Patch Set #6, Line 473: sleep(1);

    Is this specified somewhere? It seems incredibly long.

To view, visit change 23057. To unsubscribe, or for help writing mail filters, visit settings.