This looks good to me. Just one request - Can you move the entry in flashchips.c down so it's with the other W25Q256 entries?

Otherwise I'll move my W25Q256JW_DTR entry up so it's closer to where yours is.

Patch set 8:Code-Review -1

View Change

To view, visit change 40855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3608945a38b5ed42b8b2b9b2b388cdea97141d7b
Gerrit-Change-Number: 40855
Gerrit-PatchSet: 8
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 15 Jun 2020 22:55:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment