Attention is currently required from: Angel Pons, Nikolai Artemiev, Sergii Dmytruk.
4 comments:
File spi25_statusreg.c:
Patch Set #14, Line 51: int result = spi_send_multicommand(flash, cmds);
I think you're referring to the fact that it declares a variable in the middle of the function? Ther […]
Ack
File spi25_statusreg.c:
Changed in latest patch set.
Well, it's one thing to avoid a kludge for new use cases but something
different to change behavior for existing use cases. Unless we want
to test a lot of 15+ years old chips, please keep the behavior for SR1.
I'd be ok to risk to break things, but that would have to be a commit
on its own, e.g. after this series, a patch that removes the kludge even
for SR1.
Done
Doesn't look done.
I'm not sure but I guess checkpatch would see this. Please just try.
See [1] for Linus' reasoning and [2] for the style choices in coreboot
(which avoids C++ comments but should be compatible with the style used
here).
[1] https://lkml.org/lkml/2016/7/8/625
[2] https://doc.coreboot.org/contributing/coding_style.html#commenting
The next commit adds nested ifs for handling chips with different ways of writing the same register, […]
Are you saying one can't use an if inside switch/case? I've looked
ahead and I don't see any real problem.
To view, visit change 58475. To unsubscribe, or for help writing mail filters, visit settings.