Attention is currently required from: Edward O'Callaghan, Alexander Goncharov.

View Change

1 comment:

• File dummyflasher.c:

  • Patch Set #2, Line 1416:

    data->refs_cnt += ((dummy_buses_supported & BUS_PROG) != BUS_NONE);
    	data->refs_cnt += ((dummy_buses_supported & BUS_NONSPI) != BUS_NONE);
    	data->refs_cnt += ((dummy_buses_supported & BUS_SPI) != BUS_NONE);
    
    #if 0
    	data->refs_cnt += (dummy_buses_supported & BUS_PROG) ? 1 : 0;
    	data->refs_cnt += (dummy_buses_supported & BUS_NONSPI) ? 1 : 0;
    	data->refs_cnt += (dummy_buses_supported & BUS_SPI) ? 1 : 0;
    #endif
    

    Okay, I understand, thanks for explanation! […]

    Another thing could be to add `&& !ret` to every condition. Because even if one register fails -> init fails -> no need to try register remaining masters?

To view, visit change 72408. To unsubscribe, or for help writing mail filters, visit settings.