10 comments:
static int it85xx_spi_send_command(const struct flashctx *flash,
unsigned int writecnt, unsigned int readcnt,
const unsigned char *writearr,
unsigned char *readarr);
this forward declaration can be deleted if in a patch before this one - you will need to move the it […]
Done
static const struct spi_master spi_master_it85xx = {
.max_data_read = 64,
.max_data_write = 64,
.command = it85xx_spi_send_command,
.multicommand = default_spi_send_multicommand,
.read = default_spi_read,
.write_256 = default_spi_write_256,
.write_aai = default_spi_write_aai,
};
keep this here.
Done
static struct spi_master spi_master_it85xx = {
.max_data_read = 64,
.max_data_write = 64,
.command = it85xx_spi_send_command,
.multicommand = default_spi_send_multicommand,
.read = default_spi_read,
.write_256 = default_spi_write_256,
.write_aai = default_spi_write_aai,
};
I moved it as we discussed, it is now in the middle (no need to be on the very top).
Done
if (!data) {
msg_perr("Out of memory!\n");
return 1;
}
``` […]
Done
if (register_shutdown(it85xx_shutdown, data)) {
free(data);
return 1;
}
move to function eulogy.
Done
if (!(flash->mst)) {
msg_perr("No data in flash context!\n");
return 1;
}
I wrote get_data_from_context taking it87spi.c as an inspiration.
Done
Patch Set #2, Line 76: it85_data
call this `it85spi_data`
Done
return 0
you need to `free(data);` before the return since it is a heap allocation.
Done
msg_perr("Out of memory!\n");
return 1;
}
``` […]
Done
Patch Set #2, Line 315: data->it85xx_scratch_rom_reenter = 0;
I know the original code doesn't do it but its probably worth initialising the rest as well.
Done
To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.