Attention is currently required from: Edward O'Callaghan, Angel Pons.
View Change
1 comment:
File linux_spi.c:
Patch Set #2, Line 178: size_t max_kernel_buf_size;
s/these lines/this line/
I introduced this line here, because I remove global state in this patch, and in previous patches max_kernel_buf_size is still global and don't need local definition in init function.
What do you think?
To view, visit change 52285. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I93408c2ca846fca6a1c7eda7180862c51bd48078
Gerrit-Change-Number: 52285
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Nikolai Artemiev <nartemiev@google.com>
Gerrit-CC: Sam McNally <sammc@google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 15 Apr 2021 04:47:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment