[flashrom-gerrit] Change in ...flashrom[master]: flashchips.c: Make end of line comments consistent

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. (
https://review.coreboot.org/c/flashrom/+/33830 )

Change subject: flashchips.c: Make end of line comments consistent
......................................................................

flashchips.c: Make end of line comments consistent

To allow automated tools to manipulate flashchips.c, make end of line
comment formatting more consistent. Specifically, this change moves the
comma from end of line to immediately after the field value, before the
commment.

Signed-off-by: Alan Green <avg(a)google.com>
Change-Id: Ic4f97454766eff640b26a6c6eca29dc56c34c444
Reviewed-on: https://review.coreboot.org/c/flashrom/+/33830
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
M flashchips.c
1 file changed, 21 insertions(+), 21 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved



diff --git a/flashchips.c b/flashchips.c
index 8bbf15b..4e199b0 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -2560,7 +2560,7 @@
 			}
 		},
 		.printlock	= spi_prettyprint_status_register_plain, /* TODO: improve */
-		.write		= NULL /* Incompatible Page write */,
+		.write		= NULL, /* Incompatible Page write */
 		.read		= spi_chip_read,
 		.voltage	= {2700, 3600},
 	},
@@ -2667,8 +2667,8 @@
 		.bustype	= BUS_SPI,
 		.manufacture_id	= ATMEL_ID,
 		.model_id	= ATMEL_AT45CS1282,
-		.total_size	= 16896 /* No power of two sizes */,
-		.page_size	= 1056 /* No power of two sizes */,
+		.total_size	= 16896, /* No power of two sizes */
+		.page_size	= 1056, /* No power of two sizes */
 		/* does not support EWSR nor WREN and has no writable status register bits whatsoever
*/
 		/* OTP: 128B total, 64B pre-programmed; read 0x77 (4 dummy bytes); write 0x9A (via
buffer) */
 		.feature_bits	= FEATURE_OTP,
@@ -2699,8 +2699,8 @@
 		.bustype	= BUS_SPI,
 		.manufacture_id	= ATMEL_ID,
 		.model_id	= ATMEL_AT45DB011D,
-		.total_size	= 128 /* or 132, determined from status register */,
-		.page_size	= 256 /* or 264, determined from status register */,
+		.total_size	= 128, /* or 132, determined from status register */
+		.page_size	= 256, /* or 264, determined from status register */
 		/* does not support EWSR nor WREN and has no writable status register bits whatsoever
*/
 		/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
 		.feature_bits	= FEATURE_OTP,
@@ -2741,8 +2741,8 @@
 		.bustype	= BUS_SPI,
 		.manufacture_id	= ATMEL_ID,
 		.model_id	= ATMEL_AT45DB021D,
-		.total_size	= 256 /* or 264, determined from status register */,
-		.page_size	= 256 /* or 264, determined from status register */,
+		.total_size	= 256, /* or 264, determined from status register */
+		.page_size	= 256, /* or 264, determined from status register */
 		/* does not support EWSR nor WREN and has no writable status register bits whatsoever
*/
 		/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
 		.feature_bits	= FEATURE_OTP,
@@ -2783,8 +2783,8 @@
 		.bustype	= BUS_SPI,
 		.manufacture_id	= ATMEL_ID,
 		.model_id	= ATMEL_AT45DB041D,
-		.total_size	= 512 /* or 528, determined from status register */,
-		.page_size	= 256 /* or 264, determined from status register */,
+		.total_size	= 512, /* or 528, determined from status register */
+		.page_size	= 256, /* or 264, determined from status register */
 		/* does not support EWSR nor WREN and has no writable status register bits whatsoever
*/
 		/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
 		.feature_bits	= FEATURE_OTP,
@@ -2825,8 +2825,8 @@
 		.bustype	= BUS_SPI,
 		.manufacture_id	= ATMEL_ID,
 		.model_id	= ATMEL_AT45DB081D,
-		.total_size	= 1024 /* or 1056, determined from status register */,
-		.page_size	= 256 /* or 264, determined from status register */,
+		.total_size	= 1024, /* or 1056, determined from status register */
+		.page_size	= 256, /* or 264, determined from status register */
 		/* does not support EWSR nor WREN and has no writable status register bits whatsoever
*/
 		/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
 		.feature_bits	= FEATURE_OTP,
@@ -2867,8 +2867,8 @@
 		.bustype	= BUS_SPI,
 		.manufacture_id	= ATMEL_ID,
 		.model_id	= ATMEL_AT45DB161D,
-		.total_size	= 2048 /* or 2112, determined from status register */,
-		.page_size	= 512 /* or 528, determined from status register */,
+		.total_size	= 2048, /* or 2112, determined from status register */
+		.page_size	= 512, /* or 528, determined from status register */
 		/* does not support EWSR nor WREN and has no writable status register bits whatsoever
*/
 		/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
 		.feature_bits	= FEATURE_OTP,
@@ -2909,8 +2909,8 @@
 		.bustype	= BUS_SPI,
 		.manufacture_id	= ATMEL_ID,
 		.model_id	= ATMEL_AT45DB321C,
-		.total_size	= 4224 /* No power of two sizes */,
-		.page_size	= 528 /* No power of two sizes */,
+		.total_size	= 4224, /* No power of two sizes */
+		.page_size	= 528, /* No power of two sizes */
 		/* does not support EWSR nor WREN and has no writable status register bits whatsoever
*/
 		/* OTP: 128B total, 64B pre-programmed; read 0x77 (4 dummy bytes); write 0x9A (via
buffer) */
 		.feature_bits	= FEATURE_OTP,
@@ -2952,8 +2952,8 @@
 		.bustype	= BUS_SPI,
 		.manufacture_id	= ATMEL_ID,
 		.model_id	= ATMEL_AT45DB321D,
-		.total_size	= 4096 /* or 4224, determined from status register */,
-		.page_size	= 512 /* or 528, determined from status register */,
+		.total_size	= 4096, /* or 4224, determined from status register */
+		.page_size	= 512, /* or 528, determined from status register */
 		/* does not support EWSR nor WREN and has no writable status register bits whatsoever
*/
 		/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
 		.feature_bits	= FEATURE_OTP,
@@ -2994,8 +2994,8 @@
 		.bustype	= BUS_SPI,
 		.manufacture_id	= ATMEL_ID,
 		.model_id	= ATMEL_AT45DB321C,
-		.total_size	= 4096 /* or 4224, determined from status register */,
-		.page_size	= 512 /* or 528, determined from status register */,
+		.total_size	= 4096, /* or 4224, determined from status register */
+		.page_size	= 512, /* or 528, determined from status register */
 		/* does not support EWSR nor WREN and has no writable status register bits whatsoever
*/
 		/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
 		.feature_bits	= FEATURE_OTP,
@@ -3036,8 +3036,8 @@
 		.bustype	= BUS_SPI,
 		.manufacture_id	= ATMEL_ID,
 		.model_id	= ATMEL_AT45DB642D,
-		.total_size	= 8192 /* or 8448, determined from status register */,
-		.page_size	= 1024 /* or 1056, determined from status register */,
+		.total_size	= 8192, /* or 8448, determined from status register */
+		.page_size	= 1024, /* or 1056, determined from status register */
 		/* does not support EWSR nor WREN and has no writable status register bits whatsoever
*/
 		/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
 		.feature_bits	= FEATURE_OTP,

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/33830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic4f97454766eff640b26a6c6eca29dc56c34c444
Gerrit-Change-Number: 33830
Gerrit-PatchSet: 9
Gerrit-Owner: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: merged