Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Kane Chen, Kane Chen, Subrata Banik.
View Change
1 comment:
File meson_options.txt:
Patch Set #3, Line 9: option('use_libpci_ecam', type : 'boolean', value : false)
My original thought is to avoid any potential impact since i only have chromebooks to verify. […]
Yeah, I feel pretty comfortable assuming any system using a 100-series PCH should support ECAM since they're documented to not support legacy PCI and it seems likely that any system equipped with that hardware should have the appropriate firmware support for ECAM.
It might be worth adding an item to the release notes for this change, and note that it might break badly-configured systems but is not expected to actually affect any systems.
To view, visit change 83896. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I4549f87c8b01da0a1d3d8ce0b3b75c1f5fa2cbab
Gerrit-Change-Number: 83896
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen <kane.chen@intel.com>
Gerrit-Reviewer: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-CC: Kane Chen <kane.chen@intel.corp-partner.google.com>
Gerrit-Attention: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Kane Chen <kane.chen@intel.corp-partner.google.com>
Gerrit-Attention: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Kane Chen <kane.chen@intel.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 06:19:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen <kane.chen@intel.corp-partner.google.com>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>