Edward O'Callaghan submitted this change.
it87spi.c: Fix layering violation of default_spi_read
default_spi_read() calls spi_read_chunked() with the correct
max_read value of 3 set in the spi master struct.
Change-Id: I199c81e1ba501e86dbfb7cf18e2d1556e30db62e
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/46233
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Sam McNally <sammc@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M it87spi.c
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/it87spi.c b/it87spi.c
index 8224db0..e34f5e8 100644
--- a/it87spi.c
+++ b/it87spi.c
@@ -108,7 +108,7 @@
unsigned int start, unsigned int len);
static const struct spi_master spi_master_it87xx = {
- .max_data_read = MAX_DATA_UNSPECIFIED,
+ .max_data_read = 3,
.max_data_write = MAX_DATA_UNSPECIFIED,
.command = it8716f_spi_send_command,
.multicommand = default_spi_send_multicommand,
@@ -380,7 +380,7 @@
* via a programmer parameter for the internal programmer.
*/
if ((flash->chip->total_size * 1024 > 512 * 1024)) {
- spi_read_chunked(flash, buf, start, len, 3);
+ default_spi_read(flash, buf, start, len);
} else {
mmio_readn((void *)(flash->virtual_memory + start), buf, len);
}
To view, visit change 46233. To unsubscribe, or for help writing mail filters, visit settings.