Attention is currently required from: Nico Huber, Light.
View Change
3 comments:
Commit Message:
Patch Set #2, Line 9: size_t is of size 64 bits
Not always, it could be 32 bits wide on 32-bit machines
Patch Set #2, Line 12: Still the bug is not fixed :(
I wonder if casting the `1` to `size_t` would work:
(size_t)1 << foo
File tags:
To view, visit change 62733. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad
Gerrit-Change-Number: 62733
Gerrit-PatchSet: 2
Gerrit-Owner: Light <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Light <aarya.chaumal@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 15:25:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment