Attention is currently required from: Edward O'Callaghan, Angel Pons.

View Change

1 comment:

• File flashrom.c:

  • Patch Set #13, Line 348: region->name = strdup("");

    This (and also strdup in ichspi) can leak memory.

    Long term we should fetch the regions from the programmer once and use them to build a layout that has appropriate lifetime and cleanup handled at the level of flashrom context.

    Short term we can just free region->name after every call I guess.

To view, visit change 70128. To unsubscribe, or for help writing mail filters, visit settings.