Attention is currently required from: Anton Samsonov, Anton Samsonov, Thomas Heijligen.
1 comment:
Patchset:
Although I get all kinds of build and testing errors when running `test_build.sh` […]
Yes, the script is designed for Jenkins container, and it expects a specific environment (currently being x86 Linux, all dependencies installed). We have some plans to add FreeBSD environment to run on CI, but this hasn't happened yet.
About unit tests: you can run them without running full script test_build.sh.
Because they test low level code, it typically needs fixes for each environment. I would really love to have unit tests running on as much environments as possible (out of the ones flashrom supports). Currently they run on Linux (and Jenkins keeps an eye on that), also last year I fixed them to run on top 4 BSDs. I have an idea to try fix them on mac. But the main thing, you need to have that specific environment, to run and re-run tests and fix them.
If you would like to join this adventure, you can try fix the unit tests for your environment! The most common causes for segfault in tests are two:
1) missing wrap (example https://review.coreboot.org/c/flashrom/+/73649)
2) syscall which expands into inline code (example https://review.coreboot.org/c/flashrom/+/74157)
This is optional, but if you decide to do it, thank you so so much!
There is also a doc https://flashrom.org/contrib_howtos/how_to_add_unit_test.html
I like flashrom unit tests, I can talk about them forever :)
To view, visit change 81665. To unsubscribe, or for help writing mail filters, visit settings.