Attention is currently required from: Aarya, Bill XIE.

View Change

2 comments:

• File erasure_layout.c:

  • Patch Set #1, Line 237: /* Deselect all smaller blocks covering the same region. */

    I still need to add a test for this in `tests/erase_func_algo. […]

    I made the test! CB:84783

    I need to tell you more about it! :)

    I needed to upgrade the test case so that they assert the eraseblocks invocations for write operation (it was recorded and logged, but not asserted). Previously, it was asserted for erase op only.

    With that, cases #9, 13, 20 feel the difference of CB:84614. So this is useful. I updated them to pass on current head.

    Now, about this patch, the issue it is fixing can never happen after CB:84614, however it can start re-happening after CB:84721. So the case #20 is specifically creating the situation of "nested sub-blocks", to be able to test CB:84721 later.

    I used case #20 to test this patch in isolation.

• File erasure_layout.c:

  • Patch Set #2, Line 254:

    			   We are selecting one large block instead, to send opcode once
    			   instead of sending many smaller once. */
    

    Done

    thanks!

To view, visit change 84686. To unsubscribe, or for help writing mail filters, visit settings.