Attention is currently required from: Nico Huber, Namyoon Woo, Thomas Heijligen, Edward O'Callaghan.

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    Oh good, I also didn't want this patch to wait until the code is fixed.

     I think the best is to temporarily move the code as is into a separate file that reflects that there is more to do, e.g. `fixme.c`. 

    Maybe even `fixme_for_release.c`. The name should be really annoying, so that people want to fix it.

• File spi.c:

  • Patch Set #1, Line 133:

    int probe_variable_size(struct flashctx *flash)
    {
    	unsigned int i;
    	const struct emu_data *emu_data = flash->mst->spi.data;
    

    > Also it relies on emu_data, what happens if there is some other data in the context? another struc […]

    I see. I linked CB:44879 to the bug. It should be fixed, for sure. I am thinking now to take the rest of items (after this patch).

To view, visit change 63831. To unsubscribe, or for help writing mail filters, visit settings.