Just style comments...

Patch set 1:Code-Review +1

View Change

6 comments:

• File layout.h:

  • Patch Set #1, Line 65: const

    The latter `const` should be dropped (caller doesn't care if it's const inside the implementation).

  • Patch Set #1, Line 65: int process_include_args(const struct layout_include_args * const args, struct flashrom_layout *const l);

    I would prefer to have the output parameter first.

  • Patch Set #1, Line 65: const

    same

• File layout.c:

  • Patch Set #1, Line 109: while(tmp) {

    missing space

  • Patch Set #1, Line 117: tmp = malloc(sizeof(struct layout_include_args));

    null-check

  • Patch Set #1, Line 144:

    spurious space between `*` and `const`

To view, visit change 31247. To unsubscribe, or for help writing mail filters, visit settings.