Attention is currently required from: Paul Menzel, Edward O'Callaghan, Karthik Ramasubramanian.
Patch set 2:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #2:
the whole detection logic should probably be reworked in the future, but for now adding the new revision id should be fine. i'd expect that we don't need to look at the smbus pci revision id at all for the lpc pci device with the device id 0x790e, since all of those will have the spi100 engine. right now i'd assume that we only need to distinguish between the pre-spi100 and spi100 engine
To view, visit change 63423. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2408959fbf1c105508f0a12f38418c9606280ab9
Gerrit-Change-Number: 63423
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jon Murphy <jpmurphy@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Robert Zieba <robertzieba@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Comment-Date: Fri, 08 Apr 2022 15:10:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment