Attention is currently required from: Nico Huber, Miklós Márton, Edward O'Callaghan.
View Change
1 comment:
Patchset:
Patch Set #1:
>> I actually started to work on this yesterday. […]
I realised my comment may seem odd on the top of Angel's comment.
What I wanted to say, I remember there was a conversation few weeks ago in irc, about writing a test for ni845x_spi, and it can use all the tricks that existing tests are using. So I thought maybe this is what you started?
I think, test would be ideal, thank you so much for your work! (I am happy to help)
To view, visit change 57003. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2c14361283b2da3725d9ba2cae0e1007e6be3d66
Gerrit-Change-Number: 57003
Gerrit-PatchSet: 1
Gerrit-Owner: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Wed, 18 Aug 2021 22:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Miklós Márton <martonmiklosqdev@gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment