Edward O'Callaghan submitted this change.

View Change

programmer: Smoothen register_opaque_master() API

It was impossible to register a const struct opaque_master that would
point to dynamically allocated `data`. Fix that so that we won't
have to create more mutable globals.

BUG=b:185191942
TEST=builds

Change-Id: Id3adb4cf04ae04dbe87ddb96f30871cb5f7c8ff0
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/54170
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M ichspi.c
M linux_mtd.c
M nicintel_eeprom.c
M opaque.c
M programmer.h
5 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/ichspi.c b/ichspi.c
index 57cbdee..80fcff5 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -2046,7 +2046,7 @@
 			}
 			hwseq_data.size_comp1 = tmpi;
 
-			register_opaque_master(&opaque_master_ich_hwseq);
+			register_opaque_master(&opaque_master_ich_hwseq, NULL);
 		} else {
 			register_spi_master(&spi_master_ich9, NULL);
 		}
diff --git a/linux_mtd.c b/linux_mtd.c
index 0f7ac7e..aeaecce 100644
--- a/linux_mtd.c
+++ b/linux_mtd.c
@@ -424,7 +424,7 @@
 		goto linux_mtd_init_exit;
 	}
 
-	register_opaque_master(&programmer_linux_mtd);
+	register_opaque_master(&programmer_linux_mtd, NULL);
 
 	ret = 0;
 linux_mtd_init_exit:
diff --git a/nicintel_eeprom.c b/nicintel_eeprom.c
index f95107f..e170fcf 100644
--- a/nicintel_eeprom.c
+++ b/nicintel_eeprom.c
@@ -486,7 +486,7 @@
 				return 1;
 		}
 
-		return register_opaque_master(&opaque_master_nicintel_ee_82580);
+		return register_opaque_master(&opaque_master_nicintel_ee_82580, NULL);
 	} else {
 		nicintel_eebar = rphysmap("Intel i210 NIC w/ emulated EEPROM",
 					  io_base_addr + 0x12000, MEMMAP_SIZE);
@@ -496,7 +496,7 @@
 		if (register_shutdown(nicintel_ee_shutdown_i210, NULL))
 			return 1;
 
-		return register_opaque_master(&opaque_master_nicintel_ee_i210);
+		return register_opaque_master(&opaque_master_nicintel_ee_i210, NULL);
 	}
 
 	return 1;
diff --git a/opaque.c b/opaque.c
index e3103c8..f098ffc 100644
--- a/opaque.c
+++ b/opaque.c
@@ -46,7 +46,7 @@
 	return flash->mst->opaque.erase(flash, blockaddr, blocklen);
 }
 
-int register_opaque_master(const struct opaque_master *mst)
+int register_opaque_master(const struct opaque_master *mst, void *data)
 {
 	struct registered_master rmst = {0};
 
@@ -58,5 +58,7 @@
 	}
 	rmst.buses_supported = BUS_PROG;
 	rmst.opaque = *mst;
+	if (data)
+		rmst.opaque.data = data;
 	return register_master(&rmst);
 }
diff --git a/programmer.h b/programmer.h
index ac6b058..790fcc8 100644
--- a/programmer.h
+++ b/programmer.h
@@ -725,7 +725,7 @@
 	int (*erase) (struct flashctx *flash, unsigned int blockaddr, unsigned int blocklen);
 	void *data;
 };
-int register_opaque_master(const struct opaque_master *mst);
+int register_opaque_master(const struct opaque_master *mst, void *data);
 
 /* programmer.c */
 void *fallback_map(const char *descr, uintptr_t phys_addr, size_t len);

To view, visit change 54170. To unsubscribe, or for help writing mail filters, visit settings.