View Change

8 comments:

• File flash.h:

  • Patch Set #13, Line 303: const

    Nit, `const` qualification has no meaning in the forward declaration.

• File flashrom.c:

  • Patch Set #13, Line 1383: return 1;

    This was probably added because of my misinterpretation that we
    don't allow mixing a full-image file with per-region files. Should
    be reverted to the simple `continue;` it was. All such constraints
    should be handled in a higher level.

  • Patch Set #13, Line 1470: write_buf_to_file

    Nit, rather write_buf_to_file*s*?

  • Patch Set #13, Line 1500:

    		if (ret)
    			goto out;
    

    mhmm?

  • Patch Set #13, Line 1506: #endif

    oops

  • Patch Set #13, Line 2651: if (get_num_include_args_with_files(get_layout(flash)) > 0) {

    Why check this explicitly? I'd expect read_buf_from_include_args()
    to do nothing by definition if the count is 0.

  • Patch Set #13, Line 2676: *files

    missing space

• File layout.c:

  • Patch Set #13, Line 233: for (j = 0; j < l->num_entries; j++) {

    As mentioned in PS7, `j` should start at `i + 1` otherwise you
    will check each pair (x, y) twice, once with i=x, j=y and once
    with j=x and i=y.

To view, visit change 23021. To unsubscribe, or for help writing mail filters, visit settings.