Attention is currently required from: Michał Żygowski, Angel Pons.
View Change
1 comment:
File ich_descriptors.c:
Patch Set #1, Line 955: CHIPSET_300_SERIES_CANNON_POINT
if it is not zero, then we have 300 series+ chipset
right?
exactly.
The whole thing became a bit more complex, so I went ahead and
prepared things: CB:55647. Adding TGP on top should be much easier.
I'd say
if (ICCRIBA == 0x34)
return 300_SERIES
if ("CPU Soft Strap Offset from PMC Base" != 0x6c)
warn
return 500_series
I wonder if the field is really shifted by 2 bits or if it's
just Intels weird way to say the 2 least-significant bits are 0.
To view, visit change 55577. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib61d432ab4eaf00aa4eef50d2844940e73b5cad6
Gerrit-Change-Number: 55577
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 17 Jun 2021 20:26:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski@3mdeb.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment