Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: Add support to get layout from fmap (e.g. coreboot rom) ...................................................................... Patch Set 17: (2 comments) https://review.coreboot.org/#/c/23203/17/cli_classic.c File cli_classic.c: https://review.coreboot.org/#/c/23203/17/cli_classic.c@57 PS17, Line 57: --fmap <fmapfile> read ROM layout from binary containing <fmapfile>" needs to be updated. https://review.coreboot.org/#/c/23203/16/libflashrom.c File libflashrom.c: https://review.coreboot.org/#/c/23203/16/libflashrom.c@456 PS16, Line 456: fmap_bsearch
Why is that? I don't usually work with concatenated chips... Intel for instance has to option in its descriptor to concatenate 2 chips into one 'virtual/opaque' chip. There exist boards in the wild that use this weird functionality (e.g. coreboot supported thinkpad X230)...
Now that I look at the bsearch algoritm I don't think it matters... -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 17 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh@siemens.com> Gerrit-Comment-Date: Thu, 26 Jul 2018 20:06:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No