Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Edward O'Callaghan, Anastasia Klimchuk.

View Change

19 comments:

• Patchset:

  • Patch Set #5:

    The "Build Instructions" section looks like a wall of text. It's difficult to read and navigate. Plain README used indentation for formatting, but in our case, let's use _real_ formatting - my comments suggest using **bold** format because I found it most appropriate

• File README.rst:

  • Patch Set #5, Line 26: flashrom supports building with make and meson.

    ```
    flashrom supports building with **make** and **meson**.
    ```

  • Patch Set #5, Line 38: To build flashrom you need to install the following software:

    ```
    **To build flashrom you need to install the following software:**
    ```

  • Patch Set #5, Line 48: Linux et al:

    ```
    **Linux et al:**
    ```

  • Patch Set #5, Line 54: On FreeBSD, you need the following ports:

    ```
    **On FreeBSD, you need the following ports:**
    ```

  • Patch Set #5, Line 59: On OpenBSD, you need the following ports:

    ```
    **On OpenBSD, you need the following ports:**
    ```

  • Patch Set #5, Line 64: To compile on Linux, use::

    ```
    **To compile on Linux, use**::
    ```

  • Patch Set #5, Line 68: To compile on FreeBSD, OpenBSD or DragonFly BSD, use::

    ```
    **To compile on FreeBSD, OpenBSD or DragonFly BSD, use**::
    ```

  • Patch Set #5, Line 72: To compile on Nexenta, use::

    ```
    **To compile on Nexenta, use**::
    ```

  • Patch Set #5, Line 76: To compile on Solaris, use::

    ```
    **To compile on Solaris, use**::
    ```

  • Patch Set #5, Line 80: To compile on NetBSD (with pciutils, libftdi, libusb installed in /usr/pkg/), use::

    ```
    **To compile on NetBSD (with pciutils, libftdi, libusb installed in /usr/pkg/), use**::
    ```

  • Patch Set #5, Line 84: To compile and run on Darwin/Mac OS X:

    ```
    **To compile and run on Darwin/Mac OS X:**
    ```

  • Patch Set #5, Line 89: To cross-compile on Linux for DOS:

    ```
    **To cross-compile on Linux for DOS**:
    ```

  • Patch Set #5, Line 138: To cross-compile on Linux for Windows:

    ```
    **To cross-compile on Linux for Windows:**
    ```

  • Patch Set #5, Line 152: Processor architecture dependent features:

    ```
    **Processor architecture dependent features:**
    ```

  • Patch Set #5, Line 158: Compiler quirks:

    ```
    **Compiler quirks:**
    ```

  • Patch Set #5, Line 164: Bindings:

    ```
    **Bindings:**
    ```

  • Patch Set #5, Line 197: 'make export'

    ```
    ``make export``
    ```

  • Patch Set #5, Line 203: 'make tarball'

    ```
    ``make tarball``
    ```

To view, visit change 74216. To unsubscribe, or for help writing mail filters, visit settings.