Patch set 3:Code-Review +2
View Change
1 comment:
File chipset_enable.c:
Patch Set #2, Line 2016: {0x8086, 0x02a4, B_S, DEP, "Intel", "Comet Lake", enable_flash_pch400},
It's very possible that I didn't know what I was doing :) I added a PCI ID for something that report […]
I got confused and didn't stop to think we actually use LPC PCI IDs for Intel hardware.
I think this worked because the code scans all the PCI IDs, and the ichspi code would then find the correct device to use.
To view, visit change 44420. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43b4ad1eecfed16fec59863e46d4e997fbe45f1b
Gerrit-Change-Number: 44420
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Joshua Wise <joshua@joshuawise.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 30 Aug 2020 09:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Joshua Wise <joshua@joshuawise.com>
Gerrit-MessageType: comment