It's a signed integer, why print it in hex?
Patch Set #1, Line 164:
msg_cdbg("%s: rc1 0x%x, rc2 0x%x; ", __func__, rc1, rc2);
No need to print them, they are 0 on this path.
Patch Set #1, Line 169:
Please add braces here too (they are not required by syntax but help
to maintain visual balance).
Patch Set #1, Line 171:
hwversion, chip->hwversion, ediid, chip->ediid);
Actually, I'm not sure if we want this message at all. This function
is supposed to be called multiple times with different ids. So it's
expected that they don't match.
If you want to keep it, please use a higher debug level, e.g. msg_cdbg2().
To view, visit change 23261. To unsubscribe, or for help writing mail filters, visit settings.