Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, Stefan Reinauer, David Hendricks, Christian Walter, Deomid "rojer" Ryabkov, Tim Chu.
Patch set 3:-Code-Review
View Change
2 comments:
Patchset:
Patch Set #3:
That is true, -2 can and has been abused in this project. But the mere possibility does not constitute that every -2 is an act of abuse. And particularly if you read the history of this exchange you will no doubt agree that this is not the case here.
I agree with you that David wasn't abusing his -2 rights here. Still, I'd say a -1 would've achieved the same goal (stop this change from being submitted without discussing the matter beforehand) without heating things up as much. But this is how it went, and here we are.
Patch Set #3:
I'm removing my review score from this change because I don't want to be associated with this change nor what happened during review.
To view, visit change 57589. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a
Gerrit-Change-Number: 57589
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9@fb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Christian Walter <christian.walter@9elements.com>
Gerrit-Attention: David Hendricks
Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9@fb.com>
Gerrit-Attention: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 15:24:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer@coreboot.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment