Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

3 comments:

• File spi25_statusreg.c:

  • Patch Set #9, Line 120: msg_cerr("Cannot read register: not supported by chip\n");

    Maybe I am missing something, but how nested ifs prevent using an else statement? You wrap condition […]

    There are multiple ways of writing SR2, so there's a nested if/else chain inside the `if (reg == STATUS2)` block.

    But someone may try to try to write SR2 on a chip that doesn't support it, in which case we should generate an error, even though the `if (reg == STATUS2)` block will run.

• File spi25_statusreg.c:

  • Patch Set #10, Line 119:

    }
    	else {
    	
    

    I am sorry I should have noticed this earlier, but `else` (and `else if`) needs to be on the same li […]

    Done

  • Patch Set #10, Line 130:

    flash, sizeof(read_cmd), sizeof(readarr),
    			&read_cmd, readarr);
    

    This can fit into 112 chars right? It helps to git grep when all function arguments are on one line. […]

    Done

To view, visit change 58475. To unsubscribe, or for help writing mail filters, visit settings.