Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Angel Pons, Michael Niewöhner.
View Change
1 comment:
File board_enable.c:
Patch Set #2, Line 2339: return 0;
Ok, it's roughly what I expected. And it's still what I consider the hardest
way to implement this feature. For instance, the first line, it's a probe
command by definition (cf. fourth paragraph of the manual), that does much
more than probing. So at least we'd have to change all the documentation
because of this (I expect that this is just the tip of the iceberg).
So why, for instance, would this be worse:
# tuxedo_unlock_me
# reboot
...
# flashrom -p internal -w image.rom
# poweroff
To view, visit change 56023. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb
Gerrit-Change-Number: 56023
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Comment-Date: Sun, 12 Sep 2021 21:15:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski@3mdeb.com>
Comment-In-Reply-To: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-MessageType: comment