Nico Huber would like Jacob Garber to review this change.

View Change

board_enable: Work around -Wtype-limits issue

In case of an empty `board_matches` list (i.e. on non-x86), we checked
if the `unsigned i` is smaller 0. Shuffling the computation avoids that
problem.

Change-Id: I636d73c920a7b7e7507eafe444bab8236d7acb67
Signed-off-by: Nico Huber <nico.h@gmx.de>
---
M board_enable.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/35801/1

diff --git a/board_enable.c b/board_enable.c
index 98d6fd0..a5980eb 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -2493,7 +2493,7 @@
 
 	int ret = 0;
 	unsigned int i;
-	for (i = 0; i < ARRAY_SIZE(board_matches) - 1; i++) {
+	for (i = 0; i + 1 < ARRAY_SIZE(board_matches); i++) {
 		const struct board_match *b = &board_matches[i];
 		if (b->vendor_name == NULL || b->board_name == NULL) {
 			msg_gerr("ERROR: Board enable #%d does not define a vendor and board name.\n"

To view, visit change 35801. To unsubscribe, or for help writing mail filters, visit settings.