Attention is currently required from: Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk, Peter Marheine.

View Change

2 comments:

• File layout.c:

  • Patch Set #4, Line 369: return iterator ? iterator->next : layout->head;

    This duplicates _layout_next. […]

    They have different signatures. Let's keep the discussion in CB:33542.

  • Patch Set #4, Line 418: entry->next = layout->head;

    Shouldn't this be NULL? Otherwise it's creating a reference cycle.

    No, the current version adds new entries at the list head (if the
    list is empty, it sets NULL because `layout->head` is NULL; if not,
    the new entry will point to the previous head). That's much more
    convenient unless we'd maintain a tail pointer as well. I'd like
    to avoid that unless we need to maintain some order of entries.

To view, visit change 33521. To unsubscribe, or for help writing mail filters, visit settings.