Patch Set 1: Code-Review+2

Patch Set 1:

BTW, this patch was originally sent via Github: https://github.com/flashrom/flashrom/pull/156

Seems reason to me. Thanks for doing this, perhaps we should have a README.md that is picked up by Github with instructions to redirect developers, the wiki instructions are not very friendly.

Github already picks up the README, though maybe if we have a README.md Github will pick it up? Either way I definitely agree that we should make the upstream process more obviuous.

It would be nice if people used Gerrit more often, but it's also non-trivial and a lot of developers are already using Github. Automating some aspects of pull request review with linters and CI ought to make porting much quicker/easier.

View Change

To view, visit change 43599. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idb80937bb78e173eb03f2a0c0cdd8925fcd7bfa1
Gerrit-Change-Number: 43599
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 21 Jul 2020 04:54:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment