Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, Alexander Goncharov.
2 comments:
Commit Message:
This is an important step to
remove the global state because it'll allow the programmer's data
to be used in delay functions.
Sure!
Honestly I don't like that we removed that from the commit message. It worked very well for that commit, but I still consider this as a hack or quick fix because I just wanted to move on. This shouldn't become our standard. Context is *always* useful and important for the reviewers and readers.
So, please consider using `commit 0123456789ab` or `CB:123456` in the future as I have just explained in my other comment.
Commit Message:
Patch Set #7, Line 14: TOPIC=register_master_api
How is this patch related to this topic?
Also, if you don't have a huge patch series then a topic doesn't make much sense.
To explain the relations between commits, or to reference commits for giving some context, rather mention the commit ids for already merged ones using the format `commit 0123456789ab` (12 chars) or use `CB:123456` (the number from the URL) for patches which are not merged yet. The Gerrit UI makes an URL out of it and you can easily jump to the related patches. This way you can explain your effort in your initial patch for example.
To view, visit change 66373. To unsubscribe, or for help writing mail filters, visit settings.