Patch Set 1: Code-Review-1

(1 comment)

Patch Set 1:

Sorry, I really don't want any quarrel. But if we add 15 lines
to dedup 5, I have to ask, what does this fix? Somebody put much
care into this table in the past. And now we want to destroy that
just for the sake of doing something?

I don't see why this would be an improvement. If the short forms are not obvious, maybe print their meaning as done with PREW?

 (P = PROBE, R = READ, E = ERASE, W = WRITE, - = N/A)

Sure, we can try to use the short forms and eliminate the long forms used in test_state_to_text() if that is preferred.

Just as a reminder since it's been a while: The purpose of this patch was to calculate the width of each fields in a consistent manner since the existing logic proved to be fragile.

View Change

To view, visit change 37407. To unsubscribe, or for help writing mail filters, visit settings.