Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review+1
Something seems to be wrong, Jenkins says: syntax error.
There was a latent bug with lack of escaping in debug_shell. Sent https://review.coreboot.org/c/flashrom/+/44104 to fix it. I thought it would be added to this thread as an additional commit, but apparently it created a new thread. (I know hardly anything about Gerrit; sorry about that.)
You should amend this commit. If you don't have it on your local repo anymore, there's a download button with multiple options in the Gerrit UI.
Or, if you have both commits on your local repo, just squash the changes into a single commit.
Last thing: the `Change-Id` line in the commit message is what Gerrit uses to associate commits to changes (like this one). If you squash, make sure the resulting commit message only contains one Change-Id line (the one from this change).
Ah, sorry! I figured that the escaping bugfix was kind of independent from these changes, that it would be cleaner to introduce as a separate commit. I'll squash them.
To view, visit change 43140. To unsubscribe, or for help writing mail filters, visit settings.