Attention is currently required from: Miklós Márton, Alexander Goncharov.

View Change

1 comment:

• File ni845x_spi.c:

  • Patch Set #2, Line 233: set_io_voltage_mV

    This second argument (`set_io_voltage_mV`) contains a pointer to `io_voltage_in_mV` global var. […]

    I see, that's a good finding!
    Then: you need to add one more paragraph in commit message. I think this fits into a commit (as you said "Instead of relying on global variables, pass and use their value or pointer to functions where possible") but better be explicitly mentioned in commit message.

    As an example:
    The usage of `io_voltage_in_mV` global var in `usb8452_spi_set_io_voltage` function is replaced with existing function argument `set_io_voltage_mV` since `set_io_voltage_mV` already contains the pointer to global var.

    Miklós please tell us if we are missing something!

To view, visit change 72154. To unsubscribe, or for help writing mail filters, visit settings.