View Change

2 comments:

• File sb600spi.c:

  • Patch Set #1, Line 451: (amd_gen < CHIPSET_BOLTON))

    I'm not sure. […]

    Looking at the code below again, it seems that spireadmode does not have an effect for chipsets < Bolton. Instead of returning, I would just ignore the parameter (and maybe print a warning that it's not being used)

  • Patch Set #1, Line 509:

    if (spispeed_idx >= 0 && set_speed(dev, spispeed_idx) != 0) {
    		return 1;
    	}
    	return 0;
    

    Agree. Except it would return 0 (success) if spispeed_idx < 0.

    Well, if spispeed_idx is negative, the previous code would have barfed. Is it a problem if set_speed is not called?

To view, visit change 38833. To unsubscribe, or for help writing mail filters, visit settings.