Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

Patch set 1:Code-Review +2

View Change

1 comment:

• File pickit2_spi.c:

  • Patch Set #1, Line 482: goto init_err_cleanup_exit;

    Just one comment to make this review not too boring: This actually changes
    behavior. The original version failed to call pickit2_shutdown() if its
    registration failed. It's a minor thing in this case (why would registration
    fail?). Generally it's prefered though to focus on the functional changes
    in the commit message (or just have them in a separate change).

To view, visit change 52773. To unsubscribe, or for help writing mail filters, visit settings.