Attention is currently required from: ChrisEric1 CECL, Thomas Heijligen, Nicholas Chin.

Patch set 18:Code-Review +1

View Change

12 comments:

• File vl805.c:

  • Patch Set #18, Line 58:

    drop \n line 58.

  • Patch Set #18, Line 70: unsigned int i, j;

    just scope iterators to loops.

  • Patch Set #18, Line 71:

    	uint32_t outdata;
    	uint32_t indata;
    	unsigned int curwritecnt;
    	unsigned int curreadcnt;
    

    scope to respective loop constructs..

  • Patch Set #18, Line 79: curwritecnt = min(4, writecnt - j);

    .. i.e., `uint32_t curwritecnt = min(4, writecnt - j);`

  • Patch Set #18, Line 107: programmer

    `_mcu_` ?

  • Patch Set #18, Line 117: /* Shutdown stuff. */

    remove, adds no value.

  • Patch Set #18, Line 118: dev

    just pass `vl805_data->dev` it is already well-typed.

  • Patch Set #18, Line 130: .write_aai = default_spi_write_aai,

    no need for this default hook, see CB:67479

  • Patch Set #18, Line 141:

    ditto

  • Patch Set #18, Line 146:

    nit: drop this \n

  • Patch Set #18, Line 158: vl805_programmer_active(dev, 0x1)

    you seem to toggle on on line 152, read fw rev, toggle off and then immediately back on again?

  • Patch Set #18, Line 171:

    	vl805_programmer_active(dev, 0x0);
    
    	vl805_programmer_active(dev, 0x1);
    
    

    same here? if this is from a trace it could be from some silly OOP structure that always does a toggle on->do thing->toggle off pattern which leads to a lot of this kind of procedural noise.

To view, visit change 72057. To unsubscribe, or for help writing mail filters, visit settings.