Attention is currently required from: David Reguera Garcia.

Patch set 2:Code-Review +2

View Change

1 comment:

• Commit Message:

  • Patch Set #2, Line 7: buspirate_spi: return init error for invalid values of pullups, hiz, psus

    Oh one extra char! Commit title and message need to fit into 72 chars width.

    Since this is just one char, maybe just save on spaces, either remove one space after `buspirate_spi:` or replace the end with `pullups/hiz/psus`.

    Sorry, that was me suggesting this commit title, and I didn't even counted chars properly!

    I noticed you deleted the old patch and created a new one. You don't have to do this, you can push new patchset to the same patch. Locally, you amend the commit, and then push again. Keep an eye that `Change-Id` is the same, so that Gerrit knows which patch it is.

    Just in case, this is in the docs here: https://www.flashrom.org/dev_guide/development_guide.html

To view, visit change 79407. To unsubscribe, or for help writing mail filters, visit settings.