Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

6 comments:

• Commit Message:

  • Patch Set #77, Line 10:

    You can add into commit message the patch is also updating manpage for new cli commands.

    Done

  • Patch Set #77, Line 14: --wp-{enable,disable,range,list,status}

    There is also --wp-region command, you probably tested it too?

    I think I've tested it before, but to be sure I retested with a W25Q128.W flash and a simple layout file:
    ```
    0:0x7fffff a
    0:0x3fffff b
    ```

• File cli_classic.c:

  • Patch Set #77, Line 274: likley

    Typo: likley -> likely

    Done

  • Patch Set #77, Line 493: uint32_t wp_start = 0, wp_len = 0;

    Maybe move it above next to other wp variables? […]

    Done

  • Patch Set #77, Line 770: case OPTION_WP_SET_REGION:

    Is there a reason why OPTION_WP_SET_REGION comes last in the switch, and not next to all other WP op […]

    Done

  • Patch Set #77, Line 985: disable_wp

    Just to double-check: can disable_wp run together with set_wp_range or set_wp_region?

    Yep, they can run together since they're modifying different protection settings.

To view, visit change 58738. To unsubscribe, or for help writing mail filters, visit settings.