Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• File flashrom.c:

  • Patch Set #5, Line 78: int default_shutdown(void *data)

    `static int default_shutdown(void *data)`

    The reason why default_shutdown isn't static is because we're going to use it in the API. This helps us explicitly specify which of the shutdowns the programmer is using, e.g:
     
    static const struct spi_master spi_master_programmer = {
      ...
      .shutdown = default_shutdown,
    };

  • Patch Set #5, Line 104: function;

    Yes, when I mentioned "shutdown function should be required" above, in my mind it was exactly this: […]

    Do I right understand that you mean checking in register_*_master() and not in register_shutdown()?
     
    int register_spi_master(const struct spi_master *mst, void *data)
    {
      ...
      if (!mst->write_aai || ... || !mst->shutdown) {
        return ERROR_FLASHROM_BUG;
      }
      ...
    }

To view, visit change 54890. To unsubscribe, or for help writing mail filters, visit settings.