Hi,

um, sorry for the huge delay. I thought we didn't need another round
and could merge as is, then I noticed the license change. GPL v3
only just doesn't work, because parts of flashrom are v2 only. I
believe it would be best for flashrom to license new code as v2 and
later. That and v2 only are the only options.

3 comments:

File flashchips.h:
- Patch Set #4, Line 855:
```
/* 00h ST Manufacturer code  ST_ID*/
/* 01h SPI Family code       0x00*/
/* 02h Memory Density code   ST_M95XXX */
```
  This is just like it always is, imho, no need for this comment.
  If you want to keep it, please remove the ST_ID and keep it to the
  two bytes defined below (the indices are confusing because they
  refer to the specific RDID command).
File spi95.c:
- Patch Set #4, Line 8: version 3
  ugh, this is incompatible with much of flashrom (some parts are version 2
  only, doesn't mix well with 3 only)
- Patch Set #4, Line 59:
  Nit, still a spurious space after the closing parenthesis.

To view, visit change 34496. To unsubscribe, or for help writing mail filters, visit settings.